Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IzzyOnDroid modifications #423

Merged
merged 2 commits into from
Feb 24, 2025
Merged

IzzyOnDroid modifications #423

merged 2 commits into from
Feb 24, 2025

Conversation

PabloOQ
Copy link
Collaborator

@PabloOQ PabloOQ commented Feb 24, 2025

URLCheck is now available on IzzyOnDroid 🎉

  • Add IzzyOnDroid badges
  • Remove blob DEPENDENCY_INFO_BLOCK

The blob removal was requested by izzy, more info about it here. From what I've read, it is unnecesary, doesn't do anything and (although very unlikely) could result in potential issues. So it makes sense to remove it.

Since these are small changes I'll merge them myself, hope you don't mind.

Copy link
Contributor

This PR builds correctly, here is the generated apk.
This unsigned version can be installed alongside the original app and should only be used for testing the changes, not for daily usage.

Download testing apk

You must be logged in for the link to work.
The link will expire in 14 days, at Mon Mar 10 14:45:36 UTC 2025.


This is an automatic comment created by a Github Action

@PabloOQ PabloOQ merged commit e278281 into TrianguloY:master Feb 24, 2025
14 checks passed
@TrianguloY
Copy link
Owner

🥳 thank you!
Happy to see it already available too!

As for the changes, as long as that doesn't change the final apk and users can still update the app without noticing, perfect for me (it's strange because the app doesn't require any external third party library, just the android sdk and the code from this repo, so it's even better to remove any google extra unwanted bits)

Thank you for taking the time to create and manage the integration, much appreciated! 😊
I'll try to add a comment on the izzy issue to thank them too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants