Skip to content

Commit

Permalink
Merge pull request #230 from Tricentis/bugfix/sre-2307-rollout-spec-fix
Browse files Browse the repository at this point in the history 
SRE-2307 Fix rollout spec - quotes around empty annotationPrefix
  • Loading branch information
@pavel-spacil
pavel-spacil authored Nov 5, 2024
2 parents a55179e + e04ad46 commit 7ebceac
Show file tree
Hide file tree
Showing 16 changed files with 18 additions and 18 deletions.
2 changes: 1 addition & 1 deletion Charts/qtest-insights-etl/Chart.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ kubeVersion: ">=1.24.0-0"
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 1.5.2
version: 1.5.3
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
Expand Down
2 changes: 1 addition & 1 deletion Charts/qtest-insights-etl/templates/rollout.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ spec:
stableService: {{ .Values.service.serviceName }}
trafficRouting:
{{ .Values.rollouts.ingressClassName }}:
annotationPrefix: {{ .Values.ingress.canary.annotationPrefix }}
annotationPrefix: {{ .Values.ingress.canary.annotationPrefix | quote }}
{{- with .Values.ingress.canary.annotations }}
additionalIngressAnnotations:
{{- toYaml . | nindent 12 }}
Expand Down
2 changes: 1 addition & 1 deletion Charts/qtest-insights/Chart.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ icon: https://images.g2crowd.com/uploads/product/image/social_landscape/social_l
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)

version: 1.7.1
version: 1.7.2
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
Expand Down
2 changes: 1 addition & 1 deletion Charts/qtest-insights/templates/rollout.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ spec:
stableService: {{ .Values.service.serviceName }}
trafficRouting:
{{ .Values.rollouts.ingressClassName }}:
annotationPrefix: {{ .Values.ingress.canary.annotationPrefix }}
annotationPrefix: {{ .Values.ingress.canary.annotationPrefix | quote }}
{{- with .Values.ingress.canary.annotations }}
additionalIngressAnnotations:
{{- toYaml . | nindent 12 }}
Expand Down
2 changes: 1 addition & 1 deletion Charts/qtest-launch/Chart.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ kubeVersion: ">=1.24.0-0"
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)

version: 1.5.0
version: 1.5.1
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
Expand Down
2 changes: 1 addition & 1 deletion Charts/qtest-launch/templates/rollout.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ spec:
stableService: {{ .Values.service.serviceName }}
trafficRouting:
{{ .Values.rollouts.ingressClassName }}:
annotationPrefix: {{ .Values.ingress.canary.annotationPrefix }}
annotationPrefix: {{ .Values.ingress.canary.annotationPrefix | quote }}
{{- with .Values.ingress.canary.annotations }}
additionalIngressAnnotations:
{{- toYaml . | nindent 12 }}
Expand Down
2 changes: 1 addition & 1 deletion Charts/qtest-mgr/Chart.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ icon: https://images.g2crowd.com/uploads/product/image/social_landscape/social_l
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)

version: 1.9.1
version: 1.9.2
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
Expand Down
6 changes: 3 additions & 3 deletions Charts/qtest-mgr/templates/rollout.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ spec:
stableService: mgr-service
trafficRouting:
{{ .Values.rollouts.ingressClassName }}:
annotationPrefix: {{ .Values.ingress.canary.annotationPrefix }}
annotationPrefix: {{ .Values.ingress.canary.annotationPrefix | quote }}
{{- with .Values.ingress.canary.annotations }}
additionalIngressAnnotations:
{{- toYaml . | nindent 12 }}
Expand Down Expand Up @@ -53,7 +53,7 @@ spec:
stableService: mgr-service-notification
trafficRouting:
{{ .Values.rollouts.ingressClassName }}:
annotationPrefix: {{ .Values.ingress.canary.annotationPrefix }}
annotationPrefix: {{ .Values.ingress.canary.annotationPrefix | quote }}
{{- with .Values.ingress.canary.annotations }}
additionalIngressAnnotations:
{{- toYaml . | nindent 12 }}
Expand Down Expand Up @@ -85,7 +85,7 @@ spec:
stableService: mgr-service-api
trafficRouting:
{{ .Values.rollouts.ingressClassName }}:
annotationPrefix: {{ .Values.ingress.canary.annotationPrefix }}
annotationPrefix: {{ .Values.ingress.canary.annotationPrefix | quote }}
{{- with .Values.ingress.canary.annotations }}
additionalIngressAnnotations:
{{- toYaml . | nindent 12 }}
Expand Down
2 changes: 1 addition & 1 deletion Charts/qtest-parameters/Chart.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ kubeVersion: ">=1.24.0-0"
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 1.4.1
version: 1.4.2
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
Expand Down
2 changes: 1 addition & 1 deletion Charts/qtest-parameters/templates/rollout.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ spec:
stableService: {{ .Values.service.serviceName }}
trafficRouting:
{{ .Values.rollouts.ingressClassName }}:
annotationPrefix: {{ .Values.ingress.canary.annotationPrefix }}
annotationPrefix: {{ .Values.ingress.canary.annotationPrefix | quote }}
{{- with .Values.ingress.canary.annotations }}
additionalIngressAnnotations:
{{- toYaml . | nindent 12 }}
Expand Down
2 changes: 1 addition & 1 deletion Charts/qtest-pulse/Chart.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ kubeVersion: ">=1.24.0-0"
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 1.3.2
version: 1.3.3
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
Expand Down
2 changes: 1 addition & 1 deletion Charts/qtest-pulse/templates/rollout.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ spec:
stableService: {{ .Values.service.serviceName }}
trafficRouting:
{{ .Values.rollouts.ingressClassName }}:
annotationPrefix: {{ .Values.ingress.canary.annotationPrefix }}
annotationPrefix: {{ .Values.ingress.canary.annotationPrefix | quote }}
{{- with .Values.ingress.canary.annotations }}
additionalIngressAnnotations:
{{- toYaml . | nindent 12 }}
Expand Down
2 changes: 1 addition & 1 deletion Charts/qtest-scenario/Chart.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ icon: https://images.g2crowd.com/uploads/product/image/social_landscape/social_l
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 1.4.3
version: 1.4.4
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
Expand Down
2 changes: 1 addition & 1 deletion Charts/qtest-scenario/templates/rollout.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ spec:
stableService: {{ .Values.service.serviceName }}
trafficRouting:
{{ .Values.rollouts.ingressClassName }}:
annotationPrefix: {{ .Values.ingress.canary.annotationPrefix }}
annotationPrefix: {{ .Values.ingress.canary.annotationPrefix | quote }}
{{- with .Values.ingress.canary.annotations }}
additionalIngressAnnotations:
{{- toYaml . | nindent 12 }}
Expand Down
2 changes: 1 addition & 1 deletion Charts/qtest-session/Chart.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ kubeVersion: ">=1.24.0-0"
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 1.6.1
version: 1.6.2
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
Expand Down
2 changes: 1 addition & 1 deletion Charts/qtest-session/templates/rollout.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ spec:
stableService: {{ .Values.service.serviceName }}
trafficRouting:
{{ .Values.rollouts.ingressClassName }}:
annotationPrefix: {{ .Values.ingress.canary.annotationPrefix }}
annotationPrefix: {{ .Values.ingress.canary.annotationPrefix | quote }}
{{- with .Values.ingress.canary.annotations }}
additionalIngressAnnotations:
{{- toYaml . | nindent 12 }}
Expand Down

0 comments on commit 7ebceac

Please sign in to comment.