Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Insights helm chart to 1.7.0 #218

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Update Insights helm chart to 1.7.0 #218

merged 1 commit into from
Oct 18, 2024

Conversation

irunets
Copy link
Contributor

@irunets irunets commented Oct 17, 2024

Update Insights helm chart to 1.7.0

@irunets irunets requested a review from a team as a code owner October 17, 2024 07:28
@@ -125,6 +125,16 @@ spec:
secretKeyRef:
name: {{ .Values.secrets.sessionsName }}
key: client.jdbc.postgres.password
- name: INSIGHTS_RO_DB_PW

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here. It is not used anywhere. It probably had to be deleted. But as it is not used anywhere, I think it's ok to release it.

Copy link

@tomas-kuty tomas-kuty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm gicing decline because I think it does not have to be merged and released.

@irunets irunets merged commit 9497515 into main Oct 18, 2024
4 checks passed
@irunets irunets deleted the release-20243-insights branch October 21, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants