Bridge: Stop passing when too strong #168
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #167 Previous/y if no bids matched because the hand was too strong for any of them (and didn't fit the shape of others) the bot would pass unless partner's bid was forcing. This change uncaps bids when this situation is hit allowing the bot to make a bid it was otherwise too strong for (which is at least better than passing, if not always optimal).
|
Needs more discussion on whether there's a better fallback approach before this is ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #167
Previously if no bids matched because the hand was too strong for any of them (and didn't fit the shape of others) the bot would pass unless partner's bid was forcing.
This change uncaps bids when this situation is hit allowing the bot to make a bid it was otherwise too strong for (which is at least better than passing, if not always optimal).