feat: friendly numbers note revision #1220
Open
+62
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to be used in the revision_snapshot_interval widget, when it is ported to use TimeSelector
added one TODO that needs to be handled in TimeSelector: minimum allowed value (!in seconds!)
we don't do seconds only anymore, so strings needed adjusting
pano9000
force-pushed
the
feat_friendly-numbers-note-revision
branch
from
3b7cea3 to
bf41c54
Compare
|
please merge #1223 first! |
eliandoran
requested changes
Feb 20, 2025
it will fallback to the English string by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR "ports" the revisions_snapshot_interval widget to use the new TimeSelector widget that allows more user friendly time input.
still in draft, as I will need to add one additional feature to the TimeSelector widget first (i.e. setting a minimum allowed value in seconds)please first merge #1223 before merging this :-)closes #1212