Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the electron Clipboard module when using "Copy image to clipboard" #452

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

perfectra1n
Copy link

@perfectra1n perfectra1n commented Sep 29, 2024

Currently, when right clicking on an image and using "Copy image to clipboard" and then pasting the image in another application (like Trilium running in the web browser) has it paste a broken image. This is the context menu in question:
image

And this is what it shows when pasting the above image into Trilium running in the browser:
image

These changes change the context menu from using copyImageAt to electron's clipboard, and fix the above scenario.

Copy link

@eliandoran eliandoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@eliandoran eliandoran merged commit 9c8cf0b into develop Oct 11, 2024
1 check passed
@eliandoran eliandoran deleted the fix-image-copy branch October 11, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants