Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced Functionality and Styling of Cart Page #587

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Bhum-ika
Copy link

@Bhum-ika Bhum-ika commented Oct 22, 2024

Description

A clear and concise description of what the PR does.

  • This PR does the following:
    -Functionality added to display error on loading , Empty cart, and selected items conditionally
    -Styled them accordingly and separately

Fixes #547

Screenshots (if applicable)

Screenshot 2024-10-22 130743
Screenshot 2024-10-22 132416

Online.Book.Sales.-.Google.Chrome.2024-10-22.14-04-58.mp4

This is the dummy content I created to test my changes, it still has increase n decrease functionality in quantity

Additional Context

Kindly add all the tags while merging PR.
Thank you for assigning me this issue.
If you liked my contribution, kindly upgrade my level because I Not only enhanced UI but worked on functionality too.

Checklist

Make sure to check off all the items before submitting. Mark with [x] if done.

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I am working on this issue under GSSOC

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@Suman373
Copy link
Collaborator

@Bhum-ika nice work 👍 ! Are you sure your changes don't generate any new warnings ? ( you haven't filled the checkbox in the PR template)

@Suman373 Suman373 added enhancement New feature or request level2 gssoc-ext hacktoberfest-accepted For valid PRs during hacktoberfest event labels Oct 22, 2024
@Bhum-ika
Copy link
Author

Bhum-ika commented Oct 23, 2024

@Suman373
It will not generate new warnings, I have checked the tickbox now.
Could you please add level 3 here. I worked hard on this.
I would really appreciate it

@Suman373
Copy link
Collaborator

@Suman373 It will not generate new warnings, I have checked the tickbox now. Could you please add level 3 here. I worked hard on this. I would really appreciate it

Thank you !
The issue itself was labelled level2. Yes there were a lot of changes. @Trisha-tech may decide if it needs to be upgraded to level3 or not.

@Bhum-ika
Copy link
Author

@Trisha-tech Please see

@Bhum-ika
Copy link
Author

@Trisha-tech Kindly reply

@Suman373
Copy link
Collaborator

@Trisha-tech Kindly reply

Hey @Bhum-ika ! The PA might be busy and she will merge them once she gets time. Till then I'd suggest you to look into other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc-ext hacktoberfest-accepted For valid PRs during hacktoberfest event level2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Functionality of Cart Page
2 participants