allows you to specify the ip spice/vnc listens on

[joshie]

use the option "listen-ip": "some.ip" in the vm json to change which ip the vnc/spice connection is listening on,
Note: will continue to use the previous behavior if this is not specified in the json.

[rmustacc]

Hi Josh, it doesn't appear that you have signed the CLA yet. Before we can take a look at this we'd need you to sign it. More information here: http://wiki.smartos.org/display/DOC/Contributing+to+SmartOS

[joshie]

Hi, my company (Elysium Digital), has signed the CLA. I was told this was enough. Is this not accurate?

[rmustacc]

Ah, yes, if they have, then that covers it. Sorry, there's not a good way to map github user to company.

[joshie]

I wanted to ping on this. What do I need to do to get this accepted? I remember getting a list and forgetting it. Someone on the mailing list could apparently use this :)

[nshalman]

To get this patch accepted should we rebase it to the current master branch?

[Licenser]

bump, this would be a very welcome addition!

[nshalman]

The hope is for this patch to be re-implemented after IPv6 support makes it into SmartOS.
In particular it really should get some error checking.
With this patch, (at least on the version of vmadmd on which it was implemented), if you specify an IP address that doesn't exist in the GZ, vmadmd crashes.
We get by by having automation code that makes sure everything is correct, but it would be better for vmadm to do the check and bail rather than create something that causes vmadmd to crash.