Thv/degree lowering hardening

.github/workflows/coverage.yml

@@ -28,7 +28,7 @@ jobs:
         uses: taiki-e/install-action@nextest
 
       - name: Collect coverage data
-        run: cargo llvm-cov nextest --all-targets --lcov --output-path lcov.info
+        run: cargo llvm-cov nextest --lcov --output-path lcov.info
 
       - name: Upload coverage to coveralls.io
         uses: coverallsapp/github-action@v2

.github/workflows/main.yml

@@ -39,8 +39,21 @@ jobs:
       - name: Run clippy
         run: cargo clippy --all-targets -- -D warnings
 
-      - name: Run tests
-        run: cargo nextest run --no-fail-fast --all-targets
+      - name: Test triton-isa
+        run: cargo nextest run -p triton-isa --no-fail-fast --all-targets
+
+      - name: Test triton-constraint-circuit
+        run: cargo nextest run -p triton-constraint-circuit --no-fail-fast --all-targets
+
+      - name: Test triton-air
+        run: cargo nextest run -p triton-air --no-fail-fast --all-targets
+
+      - name: Test triton-constraint-builder
+        # without --all-targets because the divan benchmark doesn't play ball with nextest
+        run: cargo nextest run -p triton-constraint-builder --no-fail-fast
+
+      - name: Test triton-vm
+        run: cargo nextest run -p triton-vm --no-fail-fast --all-targets
 
         # doctests are special [^1] but this step does not incur a performance penalty [^2]
         #

Cargo.toml

@@ -93,6 +93,7 @@ test-strategy = "0.4.0"
 thiserror = "1.0"
 twenty-first = "0.42.0-alpha.9"
 unicode-width = "0.1"
+divan = "0.1.14"
 
 [workspace.lints.rust]
 let_underscore_drop = "warn"

triton-air/README.md

@@ -1,4 +1,4 @@
 # Triton VM AIR
 
 This crate is part of the [Triton VM](https://triton-vm.org) ecosystem. It contains the definition
-of the AIR constraints, which are part of the STARK proving system.
+of the AIR constraints, which are part of the STARK proving system, before degree lowering.

triton-constraint-builder/Cargo.toml

@@ -29,6 +29,11 @@ twenty-first.workspace = true
 proptest.workspace = true
 proptest-arbitrary-interop.workspace = true
 test-strategy.workspace = true
+divan.workspace = true
 
 [lints]
 workspace = true
+
+[[bench]]
+name = "degree_lowering"
+harness = false

triton-constraint-builder/benches/degree_lowering.rs

@@ -0,0 +1,91 @@
+use constraint_circuit::ConstraintCircuitMonad;
+use divan::black_box;
+use triton_constraint_builder::Constraints;
+
+fn main() {
+    divan::main();
+}
+
+#[divan::bench(sample_count = 10)]
+fn assemble_constraints() {
+    black_box(Constraints::all());
+}
+
+#[divan::bench(sample_count = 10)]
+fn initial_constraints(bencher: divan::Bencher) {
+    bencher
+        .with_inputs(|| {
+            let degree_lowering_info = Constraints::default_degree_lowering_info();
+            let constraints = Constraints::initial_constraints();
+            (degree_lowering_info, constraints)
+        })
+        .bench_values(|(degree_lowering_info, mut constraints)| {
+            black_box(ConstraintCircuitMonad::lower_to_degree(
+                &mut constraints,
+                degree_lowering_info,
+            ));
+        });
+}
+
+#[divan::bench(sample_count = 10)]
+fn consistency_constraints(bencher: divan::Bencher) {
+    bencher
+        .with_inputs(|| {
+            let degree_lowering_info = Constraints::default_degree_lowering_info();
+            let constraints = Constraints::consistency_constraints();
+            (degree_lowering_info, constraints)
+        })
+        .bench_values(|(degree_lowering_info, mut constraints)| {
+            black_box(ConstraintCircuitMonad::lower_to_degree(
+                &mut constraints,
+                degree_lowering_info,
+            ));
+        });
+}
+
+#[divan::bench(sample_count = 1)]
+fn transition_constraints(bencher: divan::Bencher) {
+    bencher
+        .with_inputs(|| {
+            let degree_lowering_info = Constraints::default_degree_lowering_info();
+            let constraints = Constraints::transition_constraints();
+            (degree_lowering_info, constraints)
+        })
+        .bench_values(|(degree_lowering_info, mut constraints)| {
+            black_box(ConstraintCircuitMonad::lower_to_degree(
+                &mut constraints,
+                degree_lowering_info,
+            ));
+        });
+}
+
+#[divan::bench(sample_count = 10)]
+fn terminal_constraints(bencher: divan::Bencher) {
+    bencher
+        .with_inputs(|| {
+            let degree_lowering_info = Constraints::default_degree_lowering_info();
+            let constraints = Constraints::terminal_constraints();
+            (degree_lowering_info, constraints)
+        })
+        .bench_values(|(degree_lowering_info, mut constraints)| {
+            black_box(ConstraintCircuitMonad::lower_to_degree(
+                &mut constraints,
+                degree_lowering_info,
+            ));
+        });
+}
+
+#[divan::bench(sample_count = 1)]
+fn degree_lower_all(bencher: divan::Bencher) {
+    bencher
+        .with_inputs(|| {
+            let constraints = Constraints::all();
+            let degree_lowering_info = Constraints::default_degree_lowering_info();
+            (degree_lowering_info, constraints)
+        })
+        .bench_values(|(degree_lowering_info, mut constraints)| {
+            black_box(
+                constraints.lower_to_target_degree_through_substitutions(degree_lowering_info),
+            );
+        });
+}

triton-constraint-builder/src/lib.rs

@@ -42,6 +42,17 @@ impl Constraints {
         }
     }
 
+    // Implementing Default for DegreeLoweringInfo is impossible because the
+    // constants are defined in crate `air` but struct `DegreeLoweringInfo` is
+    // defined in crate `triton-constraint-circuit`. Cfr. orphan rule.
+    pub fn default_degree_lowering_info() -> DegreeLoweringInfo {
+        constraint_circuit::DegreeLoweringInfo {
+            target_degree: air::TARGET_DEGREE,
+            num_main_cols: air::table::NUM_MAIN_COLUMNS,
+            num_aux_cols: air::table::NUM_AUX_COLUMNS,
+        }
+    }
+
     pub fn initial_constraints() -> Vec<ConstraintCircuitMonad<SingleRowIndicator>> {
         let circuit_builder = ConstraintCircuitBuilder::new();
         vec![