Thv/faster compilation #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build times on Tanngrisnir (my new desktop): Reduction in compilation time: 89.5 %. |
jan-ferdinand
approved these changes
Sep 19, 2024
The degree-lowering step takes up 90-95 % of the total build time. The degree-lowering code is executed in the build script `build.rs`. By default, Cargo compiles build scripts in debug mode with optimization level 0. Overriding this default leads to a 6-times speedup in the compilation time on my machine (mjolnir), as the build script execution goes from taking ~150s to ~25s. Running from a clean slate (using `cargo clean`), this change results in a speedup from 2m 29s to 52.2s.
Cache node degrees in the `pick_node_to_substitute` function which was found to be the bottle-neck in the build script. This caching shaves off 38 % of the time it takes to degree-lower, and 30 % of total build time of Triton VM. Measurements on my machine (mjolnir): degree-lowering step in build script: Before caching degrees: - 22.024172299s - 21.938811734s After caching: - 13.657397858s - 13.753980057s Total time to build triton-vm after change to `triton-constraint-circuit/src/lib.rs`: Before caching degrees: - 26.13s - 26.74s After caching: - 18.63s - 18.65s
Sword-Smith
force-pushed
the
thv/faster-compilation
branch
from
3fc3a77
to
6496a74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces compilation time by 80-90 % by:
opt-level=3ConstraintCircuitMonad::pick_node_to_substituteA benchmark of the degree-lowering code on the
thv/degree-lowering-hardeningbranch gave us the false impression that degree-lowering was only about 20 seconds. But that was when the code ran withopt-level=3which is standard for benchmarks. The default for build scripts isopt-level=0. Changing theopt-levelto 3 speeds up the build script by a factor six. And a further optimization in the degree-lowering code where the node-degrees are cached in the function that is the bottle-neck, as opposed to recalculated many times, gives another 30 % reduction in build times.