-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Command system almost-complete rework #84
Open
LichtHund
wants to merge
107
commits into
master
Choose a base branch
from
feature/big-rework
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This looks, respectfully, very sexy. I am a fan. |
Amazing. |
This was referenced Feb 2, 2023
5.0.0-beta.3 -> 5.0.0-beta.8
LichtHund
force-pushed
the
feature/big-rework
branch
from
September 13, 2023 21:47
9bd92ea
to
d856146
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
To achieve the goals I have decided to completely revamp quite a few of the systems.
This also came with an in my opinion improved syntax.
Syntax change
The previous syntax was made to avoid confusion and differentiate between method and class annotations.
Now there are no more difference on the annotations so the change makes sense.
I also find that
default
wasn't very clear what it meant, so I'm hoping the change also makes it more clear what each method does.Old
New
Nested Commands
The syntax for nested command will be the following:
Arguments as sub commands
The syntax for having arguments as sub commands.
Custom annotations
Allow users to create their own annotations and behaviors to be added to the commands.
This is currently not prototyped. Once it is I'll edit the PR.