Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mocha: Extend tests to validate status codes #20

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Mocha: Extend tests to validate status codes #20

merged 1 commit into from
Jul 17, 2024

Conversation

UlrichEckhardt
Copy link
Contributor

Instead of only checking the boolean valid result of validation, check for specific status codes as well. In particular check that invalid files emit the correct reason why they are invalid.

@UlrichEckhardt
Mocha: Extend tests
1661dab 
Instead of only checking the boolean `valid` result of validation,
check for specific status codes as well. In particular check that
invalid files emit the correct reason.
cyraxx
cyraxx approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@cyraxx cyraxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Some of these test results aren‘t semantically correct, however that’s due to things that aren’t fully implemented or possibly edge cases. For now, this correctly matches the state of the library.

@UlrichEckhardt UlrichEckhardt merged commit 7d56937 into main Jul 17, 2024
2 checks passed
@UlrichEckhardt UlrichEckhardt deleted the feature/extended-manifest-validation branch July 17, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyraxx cyraxx cyraxx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UlrichEckhardt @cyraxx