Skip to content

Commit

Permalink
Enabled all resources to export to GCP
Browse files Browse the repository at this point in the history
- for some reason, I think the resource filter is filtering out our
  traces in GCP, so I need to allow all of them so it's easier to debug
- also fixed registering the provider twice
  • Loading branch information
daniellockyer committed Nov 12, 2024
1 parent 3a2a050 commit a5367ef
Showing 1 changed file with 14 additions and 9 deletions.
23 changes: 14 additions & 9 deletions src/instrumentation.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { CloudPropagator } from '@google-cloud/opentelemetry-cloud-trace-propagator';
import { trace } from '@opentelemetry/api';
import { getNodeAutoInstrumentations } from '@opentelemetry/auto-instrumentations-node';
import { NodeSDK } from '@opentelemetry/sdk-node';
Expand Down Expand Up @@ -25,19 +26,21 @@ const sdk = new NodeSDK({
});

const provider = new NodeTracerProvider();
let propagator: CloudPropagator | undefined;

if (process.env.K_SERVICE) {
const { TraceExporter } = await import(
'@google-cloud/opentelemetry-cloud-trace-exporter'
);
provider.addSpanProcessor(new BatchSpanProcessor(new TraceExporter({})));

const { CloudPropagator } = await import(
'@google-cloud/opentelemetry-cloud-trace-propagator'
provider.addSpanProcessor(
new BatchSpanProcessor(
new TraceExporter({
resourceFilter: /.*/, // TODO: filter by our service name?
}),
),
);
provider.register({
propagator: new CloudPropagator(),
});

propagator = new CloudPropagator();
}

if (process.env.NODE_ENV === 'development') {
Expand All @@ -52,10 +55,12 @@ if (process.env.NODE_ENV === 'development') {
}),
),
);

provider.register();
}

provider.register({
propagator,
});

export const tracer = trace.getTracer('activitypub');

try {
Expand Down

0 comments on commit a5367ef

Please sign in to comment.