Correct addressing #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `to` field for Create<Article> activities was incorrectly set to the followers collection, but the content is intended to be public. This may have been causing issues with users being able to see the content depending on if they are following the actor. What we've fixed here is made public activities addressed `to` the public collection, and adding a `cc` to the followers because they are also an intended recipient, though not the primary.
Using a shared inbox make for less network requests when delivering activities and increases performance in terms of both load on the server as well as delivery times because recipients on the same server can all be informed by the same request
mike182uk
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref https://linear.app/tryghost/issue/MOM-329
The
activities was incorrectly set to thetofield for Createfollowers collection, but the content is intended to be public. This may have
been causing issues with users being able to see the content depending on if
they are following the actor.
What we've fixed here is made public activities addressed
tothe publiccollection, and adding a
ccto the followers because they are also anintended recipient, though not the primary.
Using a shared inbox make for less network requests when delivering activities
and increases performance in terms of both load on the server as well as
delivery times because recipients on the same server can all be informed by the
same request