Updated query for retrieving thread parents / children #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs [AP-579](https://linear.app/ghost/issue/AP-579/investigate-parent-post-visibility-issues-in-replies-to-articles) Updated the query for retrieving thread parents / children so that it takes into account the activity type. This is needed because when we query on the object it is possible for there to be multiple activities with a matching object if the actvity embeds the object (i.e in the case of a `Like` activity). This is important when looking up the immediate parent of an activity (as we only expect there to be 1 parent). Scoping the type of activity should be fine for our use case of "threads" (a list of comments)
mike182uk
deleted the
mike-ap-579-investigate-parent-post-visibility-issues-in-replies-to
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs AP-579
Updated the query for retrieving thread parents / children so that it takes into account the activity type. This is needed because when we query on the object it is possible for there to be multiple activities with a matching object if the actvity embeds the object (i.e in the case of a
Likeactivity). This is important when looking up the immediate parent of an activity (as we only expect there to be 1 parent). Scoping the type of activity should be fine for our use case of "threads" (a list of comments)