Optimized looking up actors when building activity #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
daniellockyer
commented
Nov 12, 2024
daniellockyer
commented
- in the case where the actor and the item's actor are the same person, we should avoid the lookup because it can be expensive
ref https://linear.app/ghost/issue/AP-583/n1-performance-problem-when-fetching-activities - in the case where the actor and the item's actor are the same person, we should avoid the lookup because it can be expensive
daniellockyer
force-pushed
the
shortcut-actor-lookup
branch
from
db5aa74 to
ce9ee6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.