Fix creating articles #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a bug where the incorrect type was being passed as the `published` property when creating an instance of Article. This should have been caught by the type system, but we were dealing with implicit `any` types for the body of the request. This change introduces the use of Zod for parsing the request body as well as providing types so that we can catch issues like this in future.
Now that we're able to skip HTTP signature verification we can easily run E2E tests with arbitrary data in the body. We have a basic setup for cumcumber tests here, including a breaking test for the post.published webhook handler.
Since the upgrade from 0.11.0-dev to 0.13.0-dev Fedify no longer accepts a datetime string for the `published` property and requires a Temporal.Instant
allouis
force-pushed
the
fix-creating-articles
branch
from
d8c944f to
eb7a68e
Compare
allouis
force-pushed
the
fix-creating-articles
branch
from
eb7a68e to
5219a3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the upgrade from 0.11.0-dev to 0.13.0-dev Fedify no longer accepts a
datetime string for the
publishedproperty and requires a Temporal.InstantWe've fixed that issue, added better types - which would have caught the
issue, and added e2e tests including a breaking test for this bug