Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added extra logging to debug mq issue with suspected incorrect context host #181

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Added extra logging to debug mq issue with suspected incorrect context host #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,9 @@ function ensureCorrectContext<B, R>(
) {
return async (ctx: Context<ContextData>, b: B) => {
const host = ctx.host;

console.log(`context host is ${host}`);

if (!ctx.data) {
(ctx as any).data = {};
}
Expand Down
11 changes: 10 additions & 1 deletion src/mq/gcloud-pubsub-mq.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,15 @@ export class GCloudPubSubMessageQueue implements MessageQueue {
if (delay !== undefined) {
this.logger.info(
`Not enqueuing message [FedifyID: ${message.id}] due to delay being set: ${delay}`,
{ message },
);

return;
}

this.logger.info(`Enqueuing message [FedifyID: ${message.id}]`);
this.logger.info(`Enqueuing message [FedifyID: ${message.id}]`, {
message,
});

try {
const messageId = await this.pubSubClient
Expand All @@ -62,10 +65,12 @@ export class GCloudPubSubMessageQueue implements MessageQueue {

this.logger.info(
`Message [FedifyID: ${message.id}] was enqueued [PubSubID: ${messageId}]`,
{ message },
);
} catch (error) {
this.logger.error(
`Failed to enqueue message [FedifyID: ${message.id}]: ${error}`,
{ message },
);

Sentry.captureException(error);
Expand Down Expand Up @@ -105,6 +110,7 @@ export class GCloudPubSubMessageQueue implements MessageQueue {
if (message.subscriptionIdentifier !== this.subscriptionIdentifier) {
this.logger.info(
`Not handling message [FedifyID: ${fedifyId}, PubSubID: ${message.id}] due to subscription mismatch [${message.subscriptionIdentifier} !== ${this.subscriptionIdentifier}]`,
{ message },
);

message.nack();
Expand All @@ -114,6 +120,7 @@ export class GCloudPubSubMessageQueue implements MessageQueue {

this.logger.info(
`Handling message [FedifyID: ${fedifyId}, PubSubID: ${message.id}]`,
{ message },
);

try {
Expand All @@ -123,12 +130,14 @@ export class GCloudPubSubMessageQueue implements MessageQueue {

this.logger.info(
`Acknowledged message [FedifyID: ${fedifyId}, PubSubID: ${message.id}]`,
{ message },
);
} catch (error) {
message.nack();

this.logger.error(
`Failed to handle message [FedifyID: ${fedifyId}, PubSubID: ${message.id}]: ${error}`,
{ message },
);

Sentry.captureException(error);
Expand Down