Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatted feature files for consistency #212

Merged
merged 1 commit into from
Nov 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,14 @@ end_of_line = lf
insert_final_newline = true
trim_trailing_whitespace = true

[*.hbs]
insert_final_newline = false

[*.json]
indent_size = 2

[*.md]
trim_trailing_whitespace = false
[*.feature]
indent_size = 2

[*.{yml,yaml}]
indent_size = 2

[Makefile]
indent_style = tab
[*.md]
trim_trailing_whitespace = false
25 changes: 12 additions & 13 deletions features/accept-follows.feature
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,16 @@ Feature: We automatically accept Follow requests
And "Alice" is in our Followers

Rule: We can be followed multiple times by the same actor, but we only record them once

Example: An actor attempts to follow us multiple times
Given an Actor "Person(Alice)"
And a "Follow(Us)" Activity "F1" by "Alice"
And a "Follow(Us)" Activity "F2" by "Alice"
When "Alice" sends "F1" to the Inbox
And "F1" is in our Inbox
And "Alice" sends "F2" to the Inbox
And "F2" is in our Inbox
Then an "Accept(F1)" Activity "A1" is created by "Us"
And an "Accept(F2)" Activity "A2" is created by "Us"
And Activity "A1" is sent to "Alice"
And Activity "A2" is sent to "Alice"
And "Alice" is in our Followers once only
Given an Actor "Person(Alice)"
And a "Follow(Us)" Activity "F1" by "Alice"
And a "Follow(Us)" Activity "F2" by "Alice"
When "Alice" sends "F1" to the Inbox
And "F1" is in our Inbox
And "Alice" sends "F2" to the Inbox
And "F2" is in our Inbox
Then an "Accept(F1)" Activity "A1" is created by "Us"
And an "Accept(F2)" Activity "A2" is created by "Us"
And Activity "A1" is sent to "Alice"
And Activity "A2" is sent to "Alice"
And "Alice" is in our Followers once only
71 changes: 36 additions & 35 deletions features/create-note.feature
Original file line number Diff line number Diff line change
@@ -1,40 +1,41 @@
Feature: Creating a note
Scenario: Note content is validated against being empty
When we attempt to create a note with no content
Then the request is rejected with a 400

Scenario: Note content is validated against being invalid
When we attempt to create a note with invalid content
Then the request is rejected with a 400
Scenario: Note content is validated against being empty
When we attempt to create a note with no content
Then the request is rejected with a 400

Scenario: Created note is added to the Outbox
When we create a note "Note" with the content
"""
Hello, world!
"""
Then "Note" is in our Outbox
Scenario: Note content is validated against being invalid
When we attempt to create a note with invalid content
Then the request is rejected with a 400

Scenario: Created note is formatted
When we create a note "Note" with the content
"""
Hello
World
"""
Then "Note" is in our Outbox
And "Note" has the content "<p>Hello<br />World</p>"
Scenario: Created note is added to the Outbox
When we create a note "Note" with the content
"""
Hello, world!
"""
Then "Note" is in our Outbox

Scenario: Created note is sent to followers
Given an Actor "Person(Alice)"
And an Actor "Person(Bob)"
And a "Follow(Us)" Activity "F1" by "Alice"
And a "Follow(Us)" Activity "F2" by "Bob"
And "Alice" sends "F1" to the Inbox
And "F1" is in our Inbox
And "Bob" sends "F2" to the Inbox
And "F2" is in our Inbox
When we create a note "Note" with the content
"""
Hello, world!
"""
Then Activity "Note" is sent to "Alice"
And Activity "Note" is sent to "Bob"
Scenario: Created note is formatted
When we create a note "Note" with the content
"""
Hello
World
"""
Then "Note" is in our Outbox
And "Note" has the content "<p>Hello<br />World</p>"

Scenario: Created note is sent to followers
Given an Actor "Person(Alice)"
And an Actor "Person(Bob)"
And a "Follow(Us)" Activity "F1" by "Alice"
And a "Follow(Us)" Activity "F2" by "Bob"
And "Alice" sends "F1" to the Inbox
And "F1" is in our Inbox
And "Bob" sends "F2" to the Inbox
And "F2" is in our Inbox
When we create a note "Note" with the content
"""
Hello, world!
"""
Then Activity "Note" is sent to "Alice"
And Activity "Note" is sent to "Bob"