Ensured activities are delivered to all followers #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs [AP-638](https://linear.app/ghost/issue/AP-638/ghost-is-not-delivering-activities-to-all-followers) Added logic to ensure that activities are delivered to all followers and not just the first page of followers
mike182uk
force-pushed
the
mike-ap-638-ghost-is-not-delivering-activities-to-all-followers
branch
from
cf5cf53 to
d1b1c6a
Compare
allouis
approved these changes
Dec 17, 2024
| const object = this.actors.Us; | ||
| const activity = await createActivity('Follow', object, actor); | ||
|
|
||
| this.activities[name] = activity; |
There was a problem hiding this comment.
Not a big deal, but this is a bit of a vague name - not sure what a better one would be, we can leave it for now I reckon, until we actually need to use them!
There was a problem hiding this comment.
Ah, I missed this, copy pasta 🍝
Have updated in 4459752 👍
mike182uk
deleted the
mike-ap-638-ghost-is-not-delivering-activities-to-all-followers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs AP-638
Added logic to ensure that activities are delivered to all followers and not just the first page of followers