Handle authorized fetch for announced objects #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some ActivityPub implementions, threads.net as one example, require the use of authorized fetch to read objects, even if they are public. When we use the `getObject` method of the Activity class the request is made without authorized fetch, which causes the handler to error. Our lookupObject helper handles the authorized fetch component, which fixes the error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some ActivityPub implementions, threads.net as one example, require the use of authorized fetch to read objects, even if they are public.
When we use the
getObjectmethod of the Activity class the request is made without authorized fetch, which causes the handler to error.Our lookupObject helper handles the authorized fetch component, which fixes the error.