Updated activities endpoint to better support client-side pagination #44
+211
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike182uk
force-pushed
the
clientside-pagination-prep
branch
from
1c740e4 to
8049770
Compare
mike182uk
force-pushed
the
clientside-pagination-prep
branch
from
8049770 to
8dd2ab6
Compare
mike182uk
force-pushed
the
clientside-pagination-prep
branch
from
8dd2ab6 to
79241ce
Compare
mike182uk
force-pushed
the
clientside-pagination-prep
branch
from
79241ce to
ff13f22
Compare
no refs In order for client-side pagination to work effectively, the activities endpoint has been updated to: - Handle filtering required on the client-side (was previously done client-side) - Return nested replies in returned activities - Expand `inReplyTo` to full object
mike182uk
force-pushed
the
clientside-pagination-prep
branch
from
ff13f22 to
edc598e
Compare
allouis
approved these changes
Sep 24, 2024
mike182uk
added a commit
to TryGhost/Ghost
that referenced
this pull request
Sep 24, 2024
refs [TryGhost/ActivityPub#44](TryGhost/ActivityPub#44) To support pagination in the activitypub app, the following changes have been made: - Move filtering and sorting of activities to the server - Refactor how comments are processed (comments are now returned as part of the activity) - Refactor how replies to own activities are processed in the activities tab (removed object map)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no refs
In order for client-side pagination to work effectively, the activities endpoint has been updated to:
inReplyToto full object