Removed redundant hasImage prop from CallToActionNode

[ronaldlangeveld]

no issue

The hasImage property was unnecessary as the presence of an image can be reliably determined by checking if imageUrl is set. This prop was originally carried over from the signup node, which has an explicit image toggle, but serves no purpose in the CallToActionNode since there's no other mechanism to enable/disable image usage.

• Removing hasImage from the node definition and defaults
• Updating conditional rendering to check imageUrl directly instead of hasImage
• Removing hasImage related test assertions
• Maintaining identical functionality while reducing code complexity

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request removes the hasImage property from the CallToActionNode and its associated logic. The node’s properties array no longer includes {name: 'hasImage', default: false}, and the rendering logic has been modified to check for an imageUrl rather than relying on a boolean flag. In the renderer file, conditions are updated to validate the existence of imageUrl before rendering image elements or applying image dimensions. Tests have been updated accordingly, with assertions and conditions relying solely on imageUrl. Additionally, in the CallToActionNodeComponent, the hasImage prop is no longer passed, ensuring uniformity across components regarding image handling.

Possibly related PRs

• Added cropped image as minimal image in CTA Card #1453: Directly addresses the removal of the hasImage property and updates to the imageUrl handling in the CallToActionNode, which aligns with the changes in this PR.
• Added image upload handling to CTA Card #1421: Enhances image upload handling in the CallToActionNodeComponent, directly related to the removal of the hasImage property and its implications in the component's logic.
• Standardize CTA component naming to CallToAction #1444: Involves modifications in the CallToActionNode component that relate to the handling of properties, indicating a direct connection at the code level with the changes in this PR.

Suggested reviewers

• ronaldlangeveld

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

yarn install v1.22.22
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6ba7773 and be4de8d.

📒 Files selected for processing (4)

• packages/kg-default-nodes/lib/nodes/call-to-action/CallToActionNode.js (1 hunks)
• packages/kg-default-nodes/lib/nodes/call-to-action/calltoaction-renderer.js (4 hunks)
• packages/kg-default-nodes/test/nodes/call-to-action.test.js (4 hunks)
• packages/koenig-lexical/src/nodes/CallToActionNodeComponent.jsx (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.