Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web & Device Extension by InfinityLoop #1186

Closed
wants to merge 22 commits into from
Closed

Web & Device Extension by InfinityLoop #1186

wants to merge 22 commits into from

Conversation

InfinityLoop1
Copy link

@InfinityLoop1 InfinityLoop1 commented Dec 7, 2023

Web & Device

Created by InfinityLoop

Web & Device is an extension created by InfinityLoop (InfinityLoopGaming on Scratch), to interact and get data from websites, your device, and your network.

Features include:

  • Change & get page title
  • Get network stats
  • Get browser, OS, and memory stats
  • Toggle & get fullscreen
  • Open and redirect tabs, get current tab, get data from URL
  • Get screen width/height
  • Get and set clipboard (not included in picture because it was added later)
  • Get battery stats and events (not included in picture because it was added later)

By the way, I have gotten comments that all of these blocks exist in other extensions. This extension is meant to combine very similar extensions, like FETCH, Navigator Info, and Network. Because it would be easier to have these all in one, instead of having to install 2 or 3 extensions to do what you want, or having to find those extensions in a long list.

Note
I wasn't aware of the “no combination extensions” rule before I had started making this extension, because this is my first extension.

@CubesterYT
Copy link
Member

CubesterYT commented Dec 7, 2023

Hello @InfinityLoopGames, Currently, the blocks from this extension are present in these other extensions:

(get data from url ()) Exists in the fetch extension.

<connected to internet>, (network type), (network generation), (browser), (current url), open url () in new tab, redirect to url () Exists in the Networking Extension.

(operating system) and (device memory) Exist in Navigator Info Extension.

(page title), set page title to (), <is page fullscreen>, enter fullscreen, exit fullscreen, (screen width), (screen height) Exist in Window Controls Extension.

Basically everything is already in other extensions...

@InfinityLoop1
Copy link
Author

@CubesterYT
Yes, this is kind of meant to combine similar extensions, they are also changed a bit.
I credited them in the code.

@CubesterYT
Copy link
Member

Alright, but I'll want to let you know that this extension may not be merged because
a. General Utility Extensions aren't allowed
b. Combination Extensions don't usually fly
c. Personal type extensions should just stay personal, instead of submitting a PR for public use.

These are part of the guidelines, but you are still allowed to keep this up till GarboMuffin reviews this.

@InfinityLoop1
Copy link
Author

I understand how it is the first two things you said, but how is this a personal type extension?

@CubesterYT
Copy link
Member

CubesterYT commented Dec 7, 2023

I understand how it is the first two things you said, but how is this a personal type extension?

@InfinityLoopGames, I didn't mean that this was a personal one, I'm just stating general rejected extensions. Sorry for any misunderstanding.

@InfinityLoop1
Copy link
Author

@CubesterYT oh ok

@CubesterYT
Copy link
Member

Also I'd like to give you a tip, don't use the master branch of your fork when contributing extensions, always use branches. Unless you're planning on deleting the fork if it gets added or rejected.

@InfinityLoop1
Copy link
Author

Oh ok, I'll do that next time I make an extension.

Copy link
Contributor

@LilyMakesThings LilyMakesThings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to review this PR in full, but as has been mentioned, a lot of this has been copy-pasted from other extensions, so I'm not going to go through the effort of reviewing the code a second time.

If you had read the contributing guidelines before submitting an extension, you would be familiar with the rule on extensions that are essentially the same as another extension (as well as "utility" extensions, that don't do a single thing).

{
opcode: "getdatafromurl",
blockType: Scratch.BlockType.REPORTER,
text: "get data from url [url]",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"get" in the text of reporters is discouraged

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't that the only word in Fetch?

Copy link
Collaborator

@CST1229 CST1229 Dec 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fetch there isn't any other noun the block could use (e.g naming the block ([url]) would be weird), and it's also called that because it makes a GET request.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So what should I use instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use fetch

@SharkPool-SP
Copy link
Collaborator

Me when Window Controls + Network + Lilys Toolbox + Browser Fullscreen + Screen Resolution extensions

@Drago-Cuven
Copy link

I understand how it is the first two things you said, but how is this a personal type extension?

i mean, there is always sharkpool's gallery.

@SharkPool-SP
Copy link
Collaborator

SharkPool-SP commented Dec 8, 2023

I understand how it is the first two things you said, but how is this a personal type extension?

i mean, there is always sharkpool's gallery.

image

@InfinityLoop1
Copy link
Author

InfinityLoop1 commented Dec 8, 2023

@SharkPool-SP
huh?

@InfinityLoop1
Copy link
Author

Fixed some issues with the extension ID, should work correctly now when ran as a file.

@GarboMuffin
Copy link
Member

i'm not going to say no at this point, but as these all kind of exist elsewhere, it'll probably be a while

i know these blocks are currently very disorganized; centralizing some of the random ones into an extension that people will actually be able to find is not a bad idea

@InfinityLoop1
Copy link
Author

Added block icons

@InfinityLoop1 InfinityLoop1 deleted the branch TurboWarp:master February 3, 2024 00:41
@InfinityLoop1 InfinityLoop1 deleted the master branch February 3, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants