-
-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web & Device Extension by InfinityLoop #1186
Conversation
Hello @InfinityLoopGames, Currently, the blocks from this extension are present in these other extensions:
Basically everything is already in other extensions... |
@CubesterYT |
Alright, but I'll want to let you know that this extension may not be merged because These are part of the guidelines, but you are still allowed to keep this up till GarboMuffin reviews this. |
I understand how it is the first two things you said, but how is this a personal type extension? |
@InfinityLoopGames, I didn't mean that this was a personal one, I'm just stating general rejected extensions. Sorry for any misunderstanding. |
@CubesterYT oh ok |
Also I'd like to give you a tip, don't use the master branch of your fork when contributing extensions, always use branches. Unless you're planning on deleting the fork if it gets added or rejected. |
Oh ok, I'll do that next time I make an extension. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to review this PR in full, but as has been mentioned, a lot of this has been copy-pasted from other extensions, so I'm not going to go through the effort of reviewing the code a second time.
If you had read the contributing guidelines before submitting an extension, you would be familiar with the rule on extensions that are essentially the same as another extension (as well as "utility" extensions, that don't do a single thing).
{ | ||
opcode: "getdatafromurl", | ||
blockType: Scratch.BlockType.REPORTER, | ||
text: "get data from url [url]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"get" in the text of reporters is discouraged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't that the only word in Fetch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fetch there isn't any other noun the block could use (e.g naming the block ([url])
would be weird), and it's also called that because it makes a GET request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So what should I use instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use fetch
Me when Window Controls + Network + Lilys Toolbox + Browser Fullscreen + Screen Resolution extensions |
i mean, there is always sharkpool's gallery. |
@SharkPool-SP |
Fixed some issues with the extension ID, should work correctly now when ran as a file. |
i'm not going to say no at this point, but as these all kind of exist elsewhere, it'll probably be a while i know these blocks are currently very disorganized; centralizing some of the random ones into an extension that people will actually be able to find is not a bad idea |
Added block icons |
Web & Device
Created by InfinityLoop
Web & Device is an extension created by InfinityLoop (InfinityLoopGaming on Scratch), to interact and get data from websites, your device, and your network.
Features include:
By the way, I have gotten comments that all of these blocks exist in other extensions. This extension is meant to combine very similar extensions, like FETCH, Navigator Info, and Network. Because it would be easier to have these all in one, instead of having to install 2 or 3 extensions to do what you want, or having to find those extensions in a long list.