Upgrading versions and use the sample-template-rails #65
Conversation
There was a problem hiding this comment.
According to GitHub's gitignore samples The following directories shouldn't be in the git tree:
/public/packs
/public/packs-test
/public/assets
You may want to review that .gitignore sample 😉
That is correct, thanks for pointing this out :) I will review it. |
Remove ruby link repository
There was a problem hiding this comment.
Please remove the webpack compiled assets from the /public folder. Also be aware that here you are only serving the bootstrap assets with webpack. You may need to move the assets from app/assets to app/javascript and import them in app/javascript/packs/application.js. See this discussion for reference.
Gemfile
Outdated
| gem 'vcr' | ||
| gem 'webdrivers' | ||
| gem 'webmock' |
There was a problem hiding this comment.
This gems are unused. In fact, since there are no e2e tests, I believe the whole :test group is not used. Can you confirm that?
Gemfile
Outdated
| gem 'overcommit', '~> 0.52.1', require: false | ||
| gem 'rubocop', '~> 0.80.0', require: false | ||
| gem 'rubocop-rails', '~> 2.4', require: false | ||
| gem 'rubocop-rspec', require: false |
There was a problem hiding this comment.
Since we are not using rspec, this shouldn't be needed.
Resolves #64
This project was updated using the sample-template-rails. Additionally, I've added the Makefile and docker-compose.