-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ChannelSuspiciousUserMessage, ChannelSuspiciousUserUpdate #29
Conversation
using System.Text; | ||
using TwitchLib.EventSub.Core.Models.ChannelSuspiciousUser; | ||
|
||
namespace TwitchLib.EventSub.Core.SubscriptionTypes.Channel |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
using System.Collections.Generic; | ||
using System.Text; | ||
|
||
namespace TwitchLib.EventSub.Core.Models.ChannelSuspiciousUser |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TwitchLib.EventSub.Core uses file scope namespace
using System.Text; | ||
using TwitchLib.EventSub.Core.Models.ChannelSuspiciousUser; | ||
|
||
namespace TwitchLib.EventSub.Core.SubscriptionTypes.Channel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TwitchLib.EventSub.Core uses file scope namespace
/// </summary> | ||
public SuspiciousUserMessage Message { get; set; } = new SuspiciousUserMessage(); | ||
|
||
public sealed class SuspiciousUserMessage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why isn't the class in its own file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seemed like it wasn't a pattern in the directory, but i didn't check super thoroughly. Will break these out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a little heads-up based on twitchdev/issues#944
/// </summary> | ||
public string UserLogin { get; set; } = string.Empty; | ||
/// <summary> | ||
/// The status set for the suspicious user. Can be the following: “none”, “active_monitoring”, or “restricted” |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: no_treatment
is sent rather than none
, despite what docs claim
/// </summary> | ||
public string[] SharedBanChannelIds { get; set; } = []; | ||
/// <summary> | ||
/// User types (if any) that apply to the suspicious user, can be “manual”, “ban_evader_detector”, or “shared_channel_ban”. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: manually_added
is sent rather than manual
, despite what docs claim
Adds
ChannelSuspiciousUserMessage
andChannelSuspiciousUserUpdate
. Both tested.Needs to be merged BEFORE TwitchLib/TwitchLib.EventSub.Websockets#31