feat(ui): rewards column in ValidatorTable is sortable #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Also moves the function to `src/utils/contracts.ts` and the PoolData type to `src/interfaces/validator.ts`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some additional fetching logic to
fetchValidatorthat runs when the app mounts, so the rewards column inValidatorTableis sortable. It leaves the queries that were already happening inside theValidatorRewardscomponent, so the data can be refetched every 30s without triggering all the other refetches fromfetchValidator.The validator metrics being fetched inside
fetchValidatorhas been refactored to:A new
TrafficLightcomponent is created to handle both cases where we show a traffic-light style indicator (validator "health" and stake saturation). There is an option to hide the indicator if the status is green/normal, which is set to true in both places.Finally, TXN-1742 is addressed here as well. The average APY calculation now excludes pools with zero balance.