refactor(network): remove name property and improve network ID types #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the unused `name` property from `NetworkConfig` interface and all related code. This property was not serving any functional purpose in the network configuration system. - Remove `name` field from `NetworkConfig` interface - Remove `name` property from all default network configurations - Update tests to remove name-related assertions and test cases
Update type signature of `setActiveNetwork` to accept both `NetworkId` enum values and custom string network IDs. This change is necessary to support custom networks while maintaining backwards compatibility with the predefined `NetworkId` enum values. - Update type signature in React, Solid, and Vue adapters - Update core `WalletManager` and store types - Maintain existing runtime behavior while improving type flexibility
drichar
force-pushed
the
refactor/network-config-enhancements
branch
from
4fda6f9 to
e0518cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the unused
nameproperty from network configurations and updates the type signature ofsetActiveNetworkto properly support both built-in and custom network IDs.nameproperty has been removed from theNetworkConfiginterface. If you're using custom network configurations, you'll need to remove anynameproperties from your configs.Details
nameproperty fromNetworkConfiginterfacenamefield from all default network configurationssetActiveNetworkto accept bothNetworkIdenum and custom string IDs