fix: Side menu scrolling #1394
Merged
fix: Side menu scrolling #1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the side menu not scrolling with the editor, if the editor is within a scrollable container (works when scrolling document body).
The PR just adds a scroll listener, which is present on all the other UI element plugins. This fixes a regression from #1132.
I spent quite some time playing around with Floating UI to try and get things working without a scroll listener, e.g. by setting
contextElementas well asgetBoundingClientRectinsetReference/setPositionReference. I also tried usingautoUpdate, but again had no luck.I think in general it might be better to keep the scroll listeners though, since it's at least clear in the codebase how those position updates are happening, whereas letting Floating UI handle them makes it less obvious what's going on.