Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

View service related imports are made dynamically #829

Merged
merged 2 commits into from
Jan 20, 2025
Merged

View service related imports are made dynamically #829

merged 2 commits into from
Jan 20, 2025

Conversation

kaisalmen
Copy link
Collaborator

Fixes #827

Included along:

  • Updated dependencies, especially updated to vitest 3
  • Properly separated langium classic and extend example, because you could only launch the one or the other. Dispose and relaunch is properly working.

@kaisalmen
fix: View service related imports are made dynamically
b7f690d 
- Updated dependencies
- Properly separated langium classic and extend example
@kaisalmen kaisalmen requested a review from CGNonofr as a code owner January 20, 2025 09:14
@kaisalmen
Copy link
Collaborator Author

kaisalmen commented Jan 20, 2025 •
edited
Loading

@CGNonofr do you have time to review/approve that today? I would like to put out a bugfix release.

CGNonofr
CGNonofr approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@CGNonofr CGNonofr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaisalmen kaisalmen merged commit 607394e into main Jan 20, 2025
1 check passed
@kaisalmen kaisalmen deleted the issue-827 branch January 20, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CGNonofr CGNonofr CGNonofr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

View service type EditorService breaks when importing anything from monaco-editor-wrapper/vscode/services
2 participants
@kaisalmen @CGNonofr