Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to monaco-vscode-api v13 #836

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Update to monaco-vscode-api v13 #836

wants to merge 5 commits into from

Conversation

kaisalmen
Copy link
Collaborator

@kaisalmen kaisalmen commented Jan 25, 2025

Applied changes according to: CodinGame/monaco-vscode-api#561 (comment)

@kaisalmen kaisalmen requested a review from CGNonofr as a code owner January 25, 2025 13:40
@kaisalmen kaisalmen marked this pull request as draft January 25, 2025 13:40
@kaisalmen
Copy link
Collaborator Author

@CGNonofr I see this error when the view service is used in the app playground example in the browser console:
image

and in the "rerender" react component test, but nowhere else in the tests:
image

I don't see this in your deployed demo or anywhere else in the examples here or apart from this one test (I pin-pointed this locally). Any idea why this comes from suddenly? I set dangerouslyIgnoreUnhandledErrors in the vitest conf, so the tests are not reported as failed. They all pass. Just this error is newly reported,

@kaisalmen
Copy link
Collaborator Author

@CGNonofr there are some problems with peerDependencies. I think. I will open an issue https://github.com/CodinGame/monaco-vscode-api and hopefully are able to describe it in an understandable way

@CGNonofr
Copy link
Collaborator

I see this error when the view service is used in the app playground example in the browser console:

I'm tired of that error, it almost as old as monaco itself: microsoft/monaco-editor#4311 but it has no other consequences than an error in the logs 🤷

I don't see this in your deployed demo or anywhere else in the examples here or apart from this one test (I pin-pointed this locally). Any idea why this comes from suddenly? I set dangerouslyIgnoreUnhandledErrors in the vitest conf, so the tests are not reported as failed. They all pass. Just this error is newly reported,

Are you sure? I can see it in https://monaco-vscode-api.netlify.app/, and also locally (just not in full-workbench mode)

there are some problems with peerDependencies.

I'm scared! any insight yet?

@kaisalmen
Copy link
Collaborator Author

I'm scared! any insight yet?

@CGNonofr am still digging. Getting there. Btw, pnpm is very helpful here, because it is way faster (due to its cache) and better standard reporting

@kaisalmen
Copy link
Collaborator Author

Are you sure? I can see it in https://monaco-vscode-api.netlify.app/, and also locally (just not in full-workbench mode)

Maybe my browser cache was not cleaned

@kaisalmen
Copy link
Collaborator Author

@CGNonofr I just pushed an update that builds three very simple projects with npm, pnpm and yarn just to check if basic dependencies work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants