-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to monaco-vscode-api v13 #836
base: main
Are you sure you want to change the base?
Conversation
Updated dependencies
@CGNonofr I see this error when the view service is used in the app playground example in the browser console: and in the "rerender" react component test, but nowhere else in the tests: I don't see this in your deployed demo or anywhere else in the examples here or apart from this one test (I pin-pointed this locally). Any idea why this comes from suddenly? I set |
- Remove pre-build workers from wrapper
@CGNonofr there are some problems with peerDependencies. I think. I will open an issue https://github.com/CodinGame/monaco-vscode-api and hopefully are able to describe it in an understandable way |
I'm tired of that error, it almost as old as monaco itself: microsoft/monaco-editor#4311 but it has no other consequences than an error in the logs 🤷
Are you sure? I can see it in https://monaco-vscode-api.netlify.app/, and also locally (just not in full-workbench mode)
I'm scared! any insight yet? |
@CGNonofr am still digging. Getting there. Btw, pnpm is very helpful here, because it is way faster (due to its cache) and better standard reporting |
Maybe my browser cache was not cleaned |
@CGNonofr I just pushed an update that builds three very simple projects with npm, pnpm and yarn just to check if basic dependencies work. |
Applied changes according to: CodinGame/monaco-vscode-api#561 (comment)