Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More for LOX #32

Merged
merged 15 commits into from
Nov 5, 2024
Merged

More for LOX #32

merged 15 commits into from
Nov 5, 2024

Conversation

JohannesMeierSE
Copy link
Collaborator

  • fixed some bugs
  • more test cases
  • validations: support for removing validations rules of removed types
  • classes:
    • support methods/functions in classes
    • UniqueMethodValidation
    • implemented AnyClassType
  • refactorings
  • unified configurations for OX and LOX

insafuhrmann
insafuhrmann approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@insafuhrmann insafuhrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @JohannesMeierSE, this looks like a helpful set of additions. I have only a few detail remarks.

examples/lox/src/language/type-system/lox-type-checking.ts Outdated Show resolved Hide resolved
examples/lox/test/lox-type-checking.test.ts Show resolved Hide resolved
examples/lox/test/lox-type-checking.test.ts Outdated Show resolved Hide resolved
packages/typir/src/kinds/class-kind.ts Show resolved Hide resolved
packages/typir/src/kinds/class-kind.ts Outdated Show resolved Hide resolved
@JohannesMeierSE
Copy link
Collaborator Author

Thanks @insafuhrmann for your helpful review! I just pushed my fixes.

@JohannesMeierSE JohannesMeierSE merged commit 857339a into main Nov 5, 2024
2 checks passed
@JohannesMeierSE JohannesMeierSE deleted the jm/more-for-lox branch December 11, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@insafuhrmann insafuhrmann insafuhrmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohannesMeierSE @insafuhrmann