Implemented changes from PR review

Reusing HelperSpeed and HelperHeading messages instead they will be used for cog and sog added comments to describe the data in HelperAISSHIP
UBCSailbot · Oct 17, 2023 · 7436387 · 7436387
1 parent 0ddf814
commit 7436387
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 10 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -32,8 +32,6 @@ set(common_msg
   "msg/HelperHeading.msg"
   "msg/HelperLatLon.msg"
   "msg/HelperSpeed.msg"
-  "msg/HelperCOG.msg"
-  "msg/HelperSOG.msg"
   "msg/HelperDimensions.msg"
   "msg/HelperROT.msg"
 )

diff --git a/msg/HelperAISShip.msg b/msg/HelperAISShip.msg
@@ -1,7 +1,11 @@
 # AIS identifier
 int32 id
 HelperLatLon lat_lon
-HelperCOG   cog
-HelperSOG   sog
+# course over ground in degrees from CW from true north
+HelperHeading   cog
+# speed over ground in kmph
+HelperSpeed   sog
+# rate of turn in degrees per hour
 HelperROT   rot
+# dimensions of the boat in meters
 HelperDimensions dimensions
diff --git a/msg/HelperCOG.msg b/msg/HelperCOG.msg
diff --git a/msg/HelperROT.msg b/msg/HelperROT.msg
@@ -1,3 +1,2 @@
-# Unit: -126 to 126 ROT AIS scale corresponds to -708 to 708 degrees per min
-# ROTAIS = 4.733 * sqrt (rot [degrees/min])
+# Unit: degrees/hour
 float32 rot
diff --git a/msg/HelperSOG.msg b/msg/HelperSOG.msg