Specify interpreter path for python extensions #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick-5546
requested changes
Jul 25, 2023
There was a problem hiding this comment.
Great catch, didn't know this could be a problem. We should also set the interpreter manually for the rest of the Python extensions: isort, flake8, and mypy (in #156)
patrick-5546
changed the title
patrick-5546
approved these changes
Jul 25, 2023
patrick-5546
pushed a commit
that referenced
this pull request
Aug 30, 2023
* Add path to python interpreter for black formatter * Add python interpreter path to isort and flake8 config
patrick-5546
added a commit
that referenced
this pull request
Oct 11, 2023
* Add mypy type checker * Create type checking vscode task and remove mypy extension * Modify mypy task to lint entire ROS packages rather than a single file * Specify interpreter path for python extensions (#155) * Add path to python interpreter for black formatter * Add python interpreter path to isort and flake8 config * Format all Python strings to be double quotes (#158) * Add github copilot extension (#159) * Delete deprecated python setting * Enable mypy extension * Add mypy task TODO * Install ament_mypy * Add mypy to CI * Update TODO * Fix mypy CI * Uncomment mypy task * Update base-dev image tag * Create mypy vscode tasks for each python pkg * Add mypy global_launch task * Fix global_launch mypy error * Loop over valid sub directories * Fix ament linter script * Uses CI script in tasks * Exit with error if any lint run has errors --------- Co-authored-by: Patrick Creighton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add path to python interpreter in workspace config file for black formatted. Without it, black would try to make assumptions on which interpreter to use and may get it wrong.