Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate website into tests #235

Merged
merged 15 commits into from
Mar 6, 2024
Merged

Integrate website into tests #235

merged 15 commits into from
Mar 6, 2024

Conversation

patrick-5546
Copy link
Member

@patrick-5546 patrick-5546 commented Jan 27, 2024

Description

To integrate the website into our tests, we will be enforcing these conventions:

  • By default and for integration, all repositories connect to the sailbot_db DB
    • No one writes to this
  • Unit tests for remote transceiver and website connect to their own DB
    • Website: TestDB
    • Remote transceiver: test

image

This PR enables the website container to run by default in the dev container and in our CI.

To Do

Verification

@patrick-5546 patrick-5546 added sim Boat Simulator team path Pathfinding team infrastructure labels Jan 27, 2024
@SPDonaghy
Copy link
Contributor

Verification

@patrick-5546 @jahn18 Is the idea that running the test task should also populate some data at http://localhost:3005/api/gps ?

I have a successful connection to the url when I run the test task, but there is no data.

@patrick-5546
Copy link
Member Author

@patrick-5546 @jahn18 Is the idea that running the test task should also populate some data at http://localhost:3005/api/gps ?

Yes once the to do's in the PR description is complete. That's why I created this PR as a draft (not ready for review)

@patrick-5546
Copy link
Member Author

Decided to change the common database name from db to sailbot_db to avoid confusion

@patrick-5546
Copy link
Member Author

@jahn18 can you switch the website to read from sailbot_db by default? I think this would require updating the .env.local file right? Would this cause any problems with running your own tests?

@patrick-5546 patrick-5546 marked this pull request as ready for review March 6, 2024 19:59
@patrick-5546 patrick-5546 enabled auto-merge (squash) March 6, 2024 20:00
@patrick-5546 patrick-5546 merged commit b21e268 into main Mar 6, 2024
12 checks passed
@patrick-5546 patrick-5546 deleted the patrick-5546/run-website branch March 6, 2024 20:10
@patrick-5546 patrick-5546 removed the sim Boat Simulator team label Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure path Pathfinding team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants