Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simulator dimension mismatches & fluid generation config #435

Merged
merged 8 commits into from
Sep 23, 2024
Merged

Simulator dimension mismatches & fluid generation config #435

merged 8 commits into from
Sep 23, 2024

Conversation

eomielan
Copy link
Member

@eomielan eomielan commented Sep 23, 2024 •
edited
Loading

Description

This PR addresses the following issues and enhancements:

  • Resolves dimension mismatches between 2D fluid generation and the expected 3D dimensions in the simulator.
  • Adds configuration options for wind and current generation properties, including mean and covariance, in globals.yaml.
  • Updates comments and certain properties within BoatProperties for clarity and accuracy.

Verification

  • Ran the simulator node alongside data collection to confirm proper data transfer and dimension alignment.

@eomielan eomielan added the sim Boat Simulator team label Sep 23, 2024
@eomielan eomielan self-assigned this Sep 23, 2024
@eomielan eomielan merged commit a11f058 into main Sep 23, 2024
10 checks passed
@eomielan eomielan deleted the user/eomielan/fix_simulator_bugs branch September 23, 2024 00:55
alberto-escobar pushed a commit that referenced this pull request Sep 28, 2024
@eomielan @alberto-escobar
Simulator dimension mismatches & fluid generation config (#435)
c29c03c 
* Fix issues in model and physics node

* Fix dimension mismatching

* Fix comments for constants

* Allow wind & current generation config

* Allow config of fluid cov in globals.yaml

* Prevent data collection from making file when not in use

* Fix formatting issues with README for ci

* Update fluid generation unit tests
vaibhavambastha pushed a commit that referenced this pull request Nov 2, 2024
@eomielan @vaibhavambastha
Simulator dimension mismatches & fluid generation config (#435)
9d46001 
* Fix issues in model and physics node

* Fix dimension mismatching

* Fix comments for constants

* Allow wind & current generation config

* Allow config of fluid cov in globals.yaml

* Prevent data collection from making file when not in use

* Fix formatting issues with README for ci

* Update fluid generation unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SPDonaghy SPDonaghy Awaiting requested review from SPDonaghy SPDonaghy is a code owner

Assignees

@eomielan eomielan

Labels
sim Boat Simulator team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eomielan