Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Fluid Generator to Produce 2D Fluids #454

Merged
merged 4 commits into from
Nov 2, 2024
Merged

Update Fluid Generator to Produce 2D Fluids #454

merged 4 commits into from
Nov 2, 2024

Conversation

kristatraboulay
Copy link
Contributor

Description

Verification

  • Ran boat simulator tests and all passed, ran roslaunch and nothing crashed

@kristatraboulay kristatraboulay self-assigned this Nov 2, 2024
eomielan
eomielan approved these changes Nov 2, 2024
View reviewed changes
Copy link
Member

@eomielan eomielan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work!

@eomielan eomielan merged commit 70ad254 into main Nov 2, 2024
10 checks passed
@eomielan eomielan deleted the kristatraboulay/447-update-FluidGenerator branch November 2, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eomielan eomielan eomielan approved these changes

@SPDonaghy SPDonaghy Awaiting requested review from SPDonaghy SPDonaghy is a code owner

Assignees

@kristatraboulay kristatraboulay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate 2D fluids with z-component zeroed out
2 participants
@kristatraboulay @eomielan