Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to fallback to default calibration in automatic configuration of MC-to-MC b-tagging SFs #1689

Merged
merged 2 commits into from
May 21, 2024

Conversation

miholzbo
Copy link
Contributor

The "auto" option to configure the b-tagging SFs currently causes failures if a sample isn't covered by the list. This PR gives an option to make this a bit more forgiven by potentially falling back to the default calibration. The default is of course to not use this.

@mdhank
Copy link
Contributor

mdhank commented May 18, 2024

Hi @miholzbo ,

You should be able to manually set the MC-MC configuration if you don't use the "auto" option. Would this work for you? I can merge this if necessary, but I think it would be safer if the auto option only works with recommended samples. That way, if it fails, users can decide on a case-by-case basis what is appropriate (for example, if you are using a sample with an unsupported Sherpa version, you may decide to use the closest Sherpa rather than the default, which I believe is Pythia).

@miholzbo
Copy link
Contributor Author

From the point of view of our analysis, we'd highly prefer having this merged. When submitting to the grid, we don't think we can properly access the name of the sample name in the xAH config file to process and deduce what calibration to apply (which would be mostly anyway the default one if not dedicated is available).

So this would quite strongly reduce the amount of bookeeping on our part, as otherwise we have to submit some samples with dedicated commandline arguments or dedicated configs.

@mdhank
Copy link
Contributor

mdhank commented May 21, 2024

Ok. Could you make the warning "Cannot determine MC shower type for sample " << gridName << ", falling back to 'default'." on L251 and L291 a bit stronger? Maybe something like:

Cannot determine MC shower type for sample " << gridName << ", falling back to 'default'. Please double-check this is appropriate for your sample!" ?

@miholzbo
Copy link
Contributor Author

That's a fair suggestion; I've added another line of warning when using the fallback option to clarify this.

@mdhank mdhank merged commit 61bc282 into UCATLAS:main May 21, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants