Fix for video #47
Merged
Fix for video #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
January 22, 2024 15:32
Requirements can now have multiple User Needs
stefpiatek
approved these changes
Jan 29, 2024
tim-band
force-pushed
the
fix-for-video
branch
from
be2b50d
to
7afb0dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loads of little things that would be embarrassing on the video, so I fixed them. None of them are tested at the moment. If you like you can hold off approval until we have tests, but there's probably no money to write them at the moment so we'd just have a PR open for however long.
Personally I'd rather have this stuff committed so that users can install qw with
pipx install git+https://github.com/UCL-ARC/qwinstead ofpipx install git+https://github.com/tim-band/qw@fix-for-video.I have opened #48, #49 and #50 to cover the additional testing required for this PR.