Issue#30 no way to read evaluations #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you resolve conflicts ? Thanks. |
|
Can you solve conflicts ? |
anthonygego
requested changes
Oct 17, 2024
templates/course_info.html
Outdated
| </tr> | ||
| {% endif %} | ||
| {% for evaluation in evaluations %} | ||
| {% if evaluation.course_year < course.year %} |
There was a problem hiding this comment.
Suggested change
| {% if evaluation.course_year < course.year %} | |
| {% if evaluation.course_year == course.year %} |
Not sure how many times you want to show the History table, but either == for each year, either one unique table with no filter at all.
There was a problem hiding this comment.
This is a history of assessments for each year of a course. So I thought that for a course in the year 2024, all the assessments equal to or preceding that year would be displayed. In the old app, it displays all the assessments for each year of a course.
Display past evaluations on the courses page Show the ‘Evaluations’ tab only if you are a researcher # Conflicts: # app.py # course.py # Conflicts: # app.py
… year of the courses
anthonygego
requested changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the possibility of viewing evaluations in courses and on researchers' profiles