-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix assign teachers #45
Open
SamuelVch98
wants to merge
20
commits into
UCL-INGI:main
Choose a base branch
from
SamuelVch98:Fix-Assign-Teachers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The diff seems to include code from #32. I'll wait for the review. |
SamuelVch98
force-pushed
the
Fix-Assign-Teachers
branch
from
October 15, 2024 17:34
7efa796
to
0012d34
Compare
Can you solve conflicts ? |
SamuelVch98
force-pushed
the
Fix-Assign-Teachers
branch
from
October 16, 2024 17:19
0012d34
to
0a82f1b
Compare
# Conflicts: # config.py # course.py # templates/layout.html # util.py
# Conflicts: # course.py
# Conflicts: # user.py
SamuelVch98
force-pushed
the
Fix-Assign-Teachers
branch
from
October 17, 2024 16:02
0a82f1b
to
24d5961
Compare
anthonygego
reviewed
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I assigned two teachers to a course and then deleted one of them, the deletion didn't happen.