Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GHA] force ubuntu-24.04 and update compilers #1552

Merged
merged 7 commits into from
Dec 12, 2024

Conversation

KrisThielemans
Copy link
Collaborator

Using ubuntu-latest as part of the "key" for ccache means we don't catch changes in the VM.

Taking the opportunity to test gcc-14.

Fixes #1550

Using ubuntu-latest as part of the "key" for ccache means we
don't catch changes in the VM.

Taking the opportunity to test gcc-14.
@KrisThielemans KrisThielemans self-assigned this Dec 11, 2024
@KrisThielemans KrisThielemans changed the title [GHA] force ubuntu-24.04 and updated compilers [GHA] force ubuntu-24.04 and update compilers Dec 11, 2024
@KrisThielemans
Copy link
Collaborator Author

CUDA install failure with gcc-14

/usr/bin/sudo /home/runner/work/STIR/STIR/cuda_installer-linux-6.8.0-1017-azure-12.1.0/cuda_installer-linux-6.8.0-1017-azure_12.1.0.run --silent --toolkit
 Failed to verify gcc version. See log at /var/log/cuda-installer.log for details.

@KrisThielemans
Copy link
Collaborator Author

@KrisThielemans
Copy link
Collaborator Author

https://github.com/UCL/STIR/actions/runs/12276026037/job/34252343981#step:9:117

CMake Error in root/cmake/ROOTConfig.cmake:
  cmake_policy PUSH without matching POP
Call Stack (most recent call first):
  src/cmake/FindCERN_ROOT.cmake:56 (find_package)
  CMakeLists.txt:121 (find_package)

The file looks fine though: https://github.com/root-project/root/blob/v6-34-00/cmake/scripts/ROOTConfig.cmake.in

@KrisThielemans
Copy link
Collaborator Author

KrisThielemans commented Dec 11, 2024

The confusing message was caused by the suppression of any useful output by doing find_package(ROOT version QUIET) in FindCERN_ROOT.cmake.

Installing vdt solves the CMake configure problem. But then we had

/usr/bin/ld: warning: libtbb.so.12, needed by /home/runner/work/STIR/STIR/root/lib/libImt.so, not found (try using -rpath or -rpath-link)

Checking https://root.cern/install/dependencies/ shows we need tbb as well

@KrisThielemans
Copy link
Collaborator Author

success. cleaning-up now

Use CUDA 12.6.1, gcc-14 is not yet supported
find_if is in <algorithm>, not <functional>

This generates an error with g++-14

Fixes UCL#1553
This prevented any diagnostics for the user.
Currently only tested on Ubuntu. Could need work on MacOS
for dependencies.
@KrisThielemans KrisThielemans linked an issue Dec 12, 2024 that may be closed by this pull request
@KrisThielemans KrisThielemans merged commit 7508bab into UCL:master Dec 12, 2024
7 checks passed
@KrisThielemans KrisThielemans deleted the GHA_Ubuntu24.04 branch December 12, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

std::find_if not found in PlasmaData.inl GitHub Actions fail, probably due to new Ubuntu 24.04
1 participant