Vsc495 connection status icons #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UniqueNameHere21
requested changes
Feb 4, 2025
There was a problem hiding this comment.
Instead of a brand new packet, lets put this in the PiPacket
| @@ -33,12 +36,11 @@ SerialReceiver::~SerialReceiver() { | |||
| void SerialReceiver::handleReadyRead() { | |||
| QByteArray data = serialPort_->readAll(); | |||
|
|
|||
| qDebug() << "Data Recieved: " << data; | |||
| qDebug() << "Data Received: " << data; | |||
There was a problem hiding this comment.
Think you can spell better than me buddy
| @@ -12,6 +14,9 @@ PacketFactory::PacketFactory() { | |||
| batteryFaultsPacket_.reset(new BatteryFaultsPacket()); | |||
| b3Packet_.reset(new B3Packet()); | |||
|
|
|||
| messageTransmitter_ = std::make_unique<MessageTransmitter>(); | |||
| connectionStatusPacket_.reset(new ConnectionStatusPacket(messageTransmitter_.get())); | |||
There was a problem hiding this comment.
I think it would be better design if me populated the connection fields directly from the transmitter class. Ie trasmitter emits a signal on success connection and on disconnection as well that will then modify the value in the packet.
Also the logic for verifying the usb connection is kind of willy nilly. And would fail to detect if usb is disconnect in the middle of runtime. Should set up a mechanism similiar to mqtt client that will monitor connect and disconnect events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.