Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEL-79-Make PIS structure for Battery Tab #70

Merged
merged 8 commits into from
Feb 25, 2024
Merged

Conversation

alexwhelan12
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Feb 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
helios-telemetry ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2024 1:55am

@alexwhelan12 alexwhelan12 reopened this Feb 10, 2024
@alexwhelan12 alexwhelan12 changed the title Refactor code to improve performance and readability TEL-79-Make PIS structure for Battery Tab Feb 10, 2024
Copy link
Member

@brian-ngyn brian-ngyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JenniferJa
JenniferJa previously approved these changes Feb 13, 2024
@alexwhelan12 alexwhelan12 dismissed JenniferJa’s stale review February 13, 2024 02:15

The merge-base changed after approval.

@JenniferJa JenniferJa self-requested a review February 13, 2024 02:17
JenniferJa
JenniferJa previously approved these changes Feb 13, 2024
IshaHaider
IshaHaider previously approved these changes Feb 13, 2024
Copy link
Contributor

@IshaHaider IshaHaider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this issue came from when rebasing Ideen's ESLint branch

@alexwhelan12 alexwhelan12 dismissed stale reviews from IshaHaider and JenniferJa February 13, 2024 02:20

The merge-base changed after approval.

IshaHaider
IshaHaider previously approved these changes Feb 13, 2024
JenniferJa
JenniferJa previously approved these changes Feb 13, 2024
@alexwhelan12 alexwhelan12 dismissed stale reviews from JenniferJa and IshaHaider February 13, 2024 02:25

The merge-base changed after approval.

brian-ngyn
brian-ngyn previously approved these changes Feb 13, 2024
IshaHaider
IshaHaider previously approved these changes Feb 13, 2024
JenniferJa
JenniferJa previously approved these changes Feb 13, 2024
ideen1
ideen1 previously approved these changes Feb 13, 2024
@alexwhelan12 alexwhelan12 dismissed stale reviews from ideen1, JenniferJa, IshaHaider, and brian-ngyn February 13, 2024 02:30

The merge-base changed after approval.

@brian-ngyn brian-ngyn merged commit eab8f06 into main Feb 25, 2024
4 checks passed
David-Rodriguez-Barrios pushed a commit that referenced this pull request Dec 18, 2024
* Refactor code to improve performance and readability

* fixed import statements

* Cross checked all battery values and updated/checked units

* Add ESLint fixes (#73)

* Add ESLint fixes

* Add ESLint fixes

* Fix ESLint check

* Fix ESLInt AGAINgit add .

* AGAIN

* FDFDSFSDF

* FDFDSFSDF

* Refactor code to improve performance and readability

* fixed import statements

* Cross checked all battery values and updated/checked units

---------

Co-authored-by: Ideen <[email protected]>
Co-authored-by: jenniferja <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants