-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C2T UI #207
Conversation
@Oddvocado See comments here => naccdata/uniform-data-set#204 |
@ashleybot is reviewing |
@Oddvocado Merged main into this C2C2T feature branch. |
@Oddvocado Turned off Turbo for the Participation Create form. Turbo expects specific HTTP response codes for different scenarios. In this one, it is simple enough to say, "We're not using Turbo here." |
@Oddvocado I formatted the instructions paragraph to follow UDSv4. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested saving a form with real world data and loading for both C2 and C2T. I fixed a couple small things and a bug with the validation of MOCATOTS.
We have some more validation cards with this one, but it's complex, so I'd like to split those into separate future cards. This is a great foundation to build upon.
- Update dependency of api libraries to
4.2.0
- Also set the version of these packages (UDS.Net.Forms and UDS.Net.Services) in this repo to
4.2.0
and tag after merge to main
Fixes #158
This PR enables users to dynamically select either the C2 or C2T form based on the modality chosen at the top of the page. The C2 form will display when Mode is set to either "In-Person" or "Remote" with the Remote Mode specified as "Video". The C2T form will display only when Mode is "Remote" and Remote Mode is "Telephone".
Previously, the dropdowns for "MODE" and "RMMODE" properties were located in the form footer partial, shared across all UDS forms. For the C2/C2T forms, these dropdowns have been relocated to the top of the form, as their values determine which form version appears.
Both forms should accurately reflect the sample forms provided by NACC, with all entity properties correctly assigned and stored in the database. When saving a form as "In-Progress," the only required validation should be the examiner's initials. Upon returning to an "In-Progress" form, the selected form version should immediately display.
To test this PR, you will need to run the UDS API on the C2T-Properties branch, and have installed the v4.2.0-preview.2 NuGet package."