Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C2T UI #207

Merged
merged 43 commits into from
Nov 7, 2024
Merged

C2T UI #207

merged 43 commits into from
Nov 7, 2024

Conversation

Oddvocado
Copy link
Member

@Oddvocado Oddvocado commented Oct 10, 2024

Fixes #158

This PR enables users to dynamically select either the C2 or C2T form based on the modality chosen at the top of the page. The C2 form will display when Mode is set to either "In-Person" or "Remote" with the Remote Mode specified as "Video". The C2T form will display only when Mode is "Remote" and Remote Mode is "Telephone".

Previously, the dropdowns for "MODE" and "RMMODE" properties were located in the form footer partial, shared across all UDS forms. For the C2/C2T forms, these dropdowns have been relocated to the top of the form, as their values determine which form version appears.

image

Both forms should accurately reflect the sample forms provided by NACC, with all entity properties correctly assigned and stored in the database. When saving a form as "In-Progress," the only required validation should be the examiner's initials. Upon returning to an "In-Progress" form, the selected form version should immediately display.

  • Both forms accurately reflect NACC official specifications
  • C2 has all correct properties and correctly persists in the database
  • C2T has all correct properties and correctly persists in the database
  • Loading an existing C2 or C2T immediately displays correct inputs and values from database

To test this PR, you will need to run the UDS API on the C2T-Properties branch, and have installed the v4.2.0-preview.2 NuGet package."

@ashleybot
Copy link
Member

@Oddvocado See comments here => naccdata/uniform-data-set#204

@Oddvocado Oddvocado marked this pull request as ready for review October 31, 2024 17:36
@ashleybot ashleybot self-requested a review October 31, 2024 17:51
@ashleybot
Copy link
Member

@ashleybot is reviewing

@ashleybot
Copy link
Member

@Oddvocado Merged main into this C2C2T feature branch.

@ashleybot
Copy link
Member

@Oddvocado Turned off Turbo for the Participation Create form. Turbo expects specific HTTP response codes for different scenarios. In this one, it is simple enough to say, "We're not using Turbo here."

Screenshot 2024-11-06 at 10 57 22 AM
Screenshot 2024-11-06 at 10 57 38 AM

@ashleybot
Copy link
Member

@Oddvocado I formatted the instructions paragraph to follow UDSv4.

Screenshot 2024-11-06 at 11 26 02 AM

Copy link
Member

@ashleybot ashleybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Oddvocado

I tested saving a form with real world data and loading for both C2 and C2T. I fixed a couple small things and a bug with the validation of MOCATOTS.

We have some more validation cards with this one, but it's complex, so I'd like to split those into separate future cards. This is a great foundation to build upon.

  • Update dependency of api libraries to 4.2.0
  • Also set the version of these packages (UDS.Net.Forms and UDS.Net.Services) in this repo to 4.2.0 and tag after merge to main

@Oddvocado Oddvocado merged commit f85859b into main Nov 7, 2024
6 checks passed
@Oddvocado Oddvocado deleted the C2T-UI branch November 7, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web App:Ui for C2T
2 participants