Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling/disabling inputs #73

Merged
merged 26 commits into from
Aug 14, 2023
Merged

Enabling/disabling inputs #73

merged 26 commits into from
Aug 14, 2023

Conversation

ashleybot
Copy link
Member

@ashleybot ashleybot commented Jul 14, 2023

Enhances validation and ui behavior (aka. enabling/disabling inputs, also called form logic).

Validation hierarchy

  • Some validation, such as range validation should run no matter the form status
  • However, required and required if properties should only fire validation if the form is attempting to be completed (aka. status = Complete)
  • Only optional forms can be saved with a status of 'Not included' and in that case the reason code is required.
  • Some forms have a different set of required fields for the initial visit vs follow-up visits. This validation is handled in the IsValid method rather than as an attribute.

Forms with behaviors

These forms are implemented:

  • A1
  • A4
  • B1
  • B4
  • B5
  • B6
  • B7
  • B8
  • C2

These forms still need to be done:

  • A2
  • A3
  • A5
  • B9
  • C1
  • D1
  • D2

@ashleybot ashleybot added the enhancement New feature or request label Jul 14, 2023
@ashleybot ashleybot self-assigned this Jul 14, 2023
@ashleybot ashleybot marked this pull request as ready for review August 2, 2023 19:45
@ashleybot
Copy link
Member Author

@smiththay This is a huge PR, so it will take you at least 1 day. Ideally, you'd to compare each of the completed forms against the current UDS app UI behavior. Where they differ, reference the official NACC documentation to determine which is correct.

Copy link
Contributor

@smiththay smiththay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Enabling/disabling inputs functions the way they should. Good work!

@ashleybot ashleybot merged commit 3d5c523 into main Aug 14, 2023
1 check passed
@ashleybot ashleybot deleted the feature-ui-behavior branch August 14, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants