Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

progress commit #76

Merged
merged 7 commits into from
Aug 4, 2023
Merged

progress commit #76

merged 7 commits into from
Aug 4, 2023

Conversation

smiththay
Copy link
Contributor

@smiththay smiththay commented Jul 25, 2023

  • Displays language selected (English or Spanish) on visit details view
  • Displays reason code when selected on visit details view
    fixes Z1 Checklist Layout #39

@smiththay smiththay marked this pull request as ready for review July 31, 2023 21:21
else if (form.Language == FormLanguage.Spanish)
cssClassFormLanguage = "bg-green-100";
}
@if (form.Language != FormLanguage.English && form.Language != FormLanguage.Spanish)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smiththay I wonder if Instead of having an empty if statement here, could it just a single if statement for the opposite to display @form.Language ?

@ashleybot ashleybot self-requested a review August 3, 2023 19:05
Copy link
Member

@ashleybot ashleybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge! There is a comment about possibly removing an empty if-statement, but doesn't need to hold anything up unless you want to change it.

Be sure to use the GitHub web ui to 'squash and merge.'

@smiththay smiththay merged commit 3669952 into main Aug 4, 2023
1 check passed
@smiththay smiththay deleted the Z1-Checklist-Layout branch August 4, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Z1 Checklist Layout
2 participants