-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes bug with reason code mapping on not included forms #77
Conversation
ashleybot
commented
Jul 27, 2023
•
edited
Loading
edited
- Only optional forms should be allowed to have NotIncluded selected as a form status
- If NotIncluded is selected then ReasonCode is required when saving the form
- When a form that has NotIncluded as status is edited, the previously selected reason code should also be displayed in the drop down
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ashleybot For me, it looks like if NotIncluded is selected then ReasonCode is not required when saving the form. I noticed A3 for some reason will not let me save InProgress or NotIncluded at all.
Ok, it definitely was not validating required reason code on Not Required. 🤡 @smiththay I have updated the code, tested again, and these cases should all be true:
There are opportunities to improve the UX further in this interaction, but that will be saved for a later date. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!