Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes bug with reason code mapping on not included forms #77

Merged
merged 6 commits into from
Aug 16, 2023

Conversation

ashleybot
Copy link
Member

@ashleybot ashleybot commented Jul 27, 2023

  • Only optional forms should be allowed to have NotIncluded selected as a form status
  • If NotIncluded is selected then ReasonCode is required when saving the form
  • When a form that has NotIncluded as status is edited, the previously selected reason code should also be displayed in the drop down

@ashleybot ashleybot marked this pull request as ready for review July 27, 2023 15:44
@ashleybot ashleybot requested a review from smiththay July 27, 2023 15:44
@ashleybot ashleybot self-assigned this Jul 27, 2023
Copy link
Contributor

@smiththay smiththay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashleybot For me, it looks like if NotIncluded is selected then ReasonCode is not required when saving the form. I noticed A3 for some reason will not let me save InProgress or NotIncluded at all.

@ashleybot
Copy link
Member Author

ashleybot commented Aug 14, 2023

Ok, it definitely was not validating required reason code on Not Required. 🤡

@smiththay I have updated the code, tested again, and these cases should all be true:

  • Forms that are not required cannot select "Not included" as a status
  • Forms that are optional can select "Not included" and require a reason code to be saved.
  • For not included forms, when a reason code is selected, the form is saved successfully. Any data supplied along witht the form is also maintained. For example, they may have recorded some of the B1 vitals, but not all and that's ok if it's not included.

There are opportunities to improve the UX further in this interaction, but that will be saved for a later date.

Copy link
Contributor

@smiththay smiththay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ashleybot ashleybot merged commit ffe03f5 into main Aug 16, 2023
1 check passed
@ashleybot ashleybot deleted the reason-code-mapping-bugfix branch August 16, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants