Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A5 Form Finalization #94

Merged
merged 5 commits into from
Oct 4, 2023
Merged

A5 Form Finalization #94

merged 5 commits into from
Oct 4, 2023

Conversation

Oddvocado
Copy link
Member

@Oddvocado Oddvocado commented Sep 22, 2023

This PR fixes #81 by implementing disabling/enabling of inputs for better UX in submission of an A5.

There are several questions in the A5 which skip a value from the typical set of response values. So, there is some custom HTML in the view to support this edge-case. You'll find these edge-case questions in section 4.

  • The A5 is only collected at initial visits.

@Oddvocado Oddvocado linked an issue Sep 22, 2023 that may be closed by this pull request
@Oddvocado Oddvocado marked this pull request as ready for review September 27, 2023 12:19
@ashleybot
Copy link
Member

@smiththay Can you review this PR?

Copy link
Contributor

@smiththay smiththay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything appears to function as it is supposed too. Good work!

@Oddvocado Oddvocado merged commit 4a1d71b into main Oct 4, 2023
1 check passed
@Oddvocado Oddvocado deleted the A5 branch October 4, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A5 Form UI Behavior and Finalization
3 participants