-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
D1 Form Finalization #97
Conversation
@smiththay Hey, since this is such a big one, can you give this a first pass and then I'll look at it after you approve? |
@smiththay is currently reviewing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Oddvocado Nice work on this complex form, especially the fancy checkboxes and section 3 validations. Only noticed one thing though. For questions 5a-5e , I can still click on the radio buttons even though I have not selected a checkbox. Validation works but it may be easier for the user if these radio buttons were disabled until the corresponding checkbox has been selected.
@smiththay Good catch! The radio buttons are now disabled when a checkbox is changed. Ready for re-review when you have a moment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Oddvocado looks good! @ashleybot I am going to pass this review to you to do a final look through.
@mlan225 Could you give a second review on this PR? |
Looks good to me 👍 |
This PR aims to finalize the D1 UDS Form. Notable changes include