Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D1 Form Finalization #97

Merged
merged 21 commits into from
Nov 16, 2023
Merged

D1 Form Finalization #97

merged 21 commits into from
Nov 16, 2023

Conversation

Oddvocado
Copy link
Member

@Oddvocado Oddvocado commented Oct 6, 2023

This PR aims to finalize the D1 UDS Form. Notable changes include

  • Adding client side validation
  • Adding server side validation
  • I added a "fancy checkboxes" stimulus controller. The intended function is to only allow users to select one checkbox for questions 5a-5e
  • Section 3 questions have now been updated to only allow the users to select 1 diagnosis as primary. If the participant has normal cognition, the primary, contributing and non-contributing fields will not store a value when the form is saved.
  • Section 3 questions have also been updated to require that users mark at least one diagnosis as present when participants do not have normal cognition.

@Oddvocado Oddvocado linked an issue Oct 6, 2023 that may be closed by this pull request
@Oddvocado Oddvocado marked this pull request as ready for review October 25, 2023 14:47
@ashleybot
Copy link
Member

@smiththay Hey, since this is such a big one, can you give this a first pass and then I'll look at it after you approve?

@ashleybot
Copy link
Member

@smiththay is currently reviewing

Copy link
Contributor

@smiththay smiththay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Oddvocado Nice work on this complex form, especially the fancy checkboxes and section 3 validations. Only noticed one thing though. For questions 5a-5e , I can still click on the radio buttons even though I have not selected a checkbox. Validation works but it may be easier for the user if these radio buttons were disabled until the corresponding checkbox has been selected.
Screenshot 2023-10-31 at 4 52 35 PM

@Oddvocado
Copy link
Member Author

@smiththay Good catch! The radio buttons are now disabled when a checkbox is changed. Ready for re-review when you have a moment.

Copy link
Contributor

@smiththay smiththay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Oddvocado looks good! @ashleybot I am going to pass this review to you to do a final look through.

@ashleybot
Copy link
Member

@mlan225 Could you give a second review on this PR?

@mlan225
Copy link
Member

mlan225 commented Nov 15, 2023

Looks good to me 👍

@Oddvocado Oddvocado merged commit 11a5e8c into main Nov 16, 2023
5 checks passed
@Oddvocado Oddvocado deleted the D1-Form branch November 16, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

D1 Form UI Behavior and Finalization
4 participants